-
Notifications
You must be signed in to change notification settings - Fork 71
Conversation
Hi @k82cn. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add api firstly, will add implementation later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Could we support advanced use cases? For example, we want to run PS in different machines and place workers around PS.
sure, we have implemented this internally; will publish it later. |
You also discussed about adding queue name. Is it planned? |
yes, queue is a key feature in the pipeline. I will add integration when it is stable, e.g. |
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@k82cn Could you please fix the typo, then I think we could merge it. Thanks |
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
fixed typo :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry for post update: there's a "feature" in upstream, named |
@k82cn Thanks for the information, Kubeflow requires k8s 1.8, does this feature exist in 1.8? |
nop, but this may make other contributor confuse. BTW, I think it should be client-go 1.8, k8s 1.11 :) |
Signed-off-by: Da K. Ma klaus1982.cn@gmail.com
part of #11
This change is