Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Added schedulingPolicy api. #13

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Conversation

k82cn
Copy link
Contributor

@k82cn k82cn commented Apr 13, 2019

Signed-off-by: Da K. Ma klaus1982.cn@gmail.com

part of #11


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @k82cn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k82cn
Copy link
Contributor Author

k82cn commented Apr 13, 2019

Add api firstly, will add implementation later.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Could we support advanced use cases? For example, we want to run PS in different machines and place workers around PS.

@k82cn
Copy link
Contributor Author

k82cn commented Apr 13, 2019

Could we support advanced use cases? For example, we want to run PS in different machines and place workers around PS.

sure, we have implemented this internally; will publish it later.

@johnugeorge
Copy link
Member

You also discussed about adding queue name. Is it planned?

@k82cn
Copy link
Contributor Author

k82cn commented Apr 13, 2019

yes, queue is a key feature in the pipeline. I will add integration when it is stable, e.g. QueueName.

@gaocegege
Copy link
Member

/ok-to-test
/cc @richardsliu

@johnugeorge
Copy link
Member

/lgtm

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaocegege
Copy link
Member

@k82cn Could you please fix the typo, then I think we could merge it. Thanks

Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
@k82cn
Copy link
Contributor Author

k82cn commented Apr 16, 2019

fixed typo :)

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e2dddfd into kubeflow:master Apr 16, 2019
@k82cn k82cn deleted the sched_policy branch April 16, 2019 23:26
@k82cn
Copy link
Contributor Author

k82cn commented Apr 16, 2019

Sorry for post update: there's a "feature" in upstream, named SchedulingPolicy, which is used to define whether a scheduler feature can be enabled, e.g. toleration. Do we need to have another term for that, e.g. SchedulingSpec?

xref kubernetes/community#1937

@gaocegege
Copy link
Member

@k82cn Thanks for the information, Kubeflow requires k8s 1.8, does this feature exist in 1.8?

@k82cn
Copy link
Contributor Author

k82cn commented Apr 17, 2019

Thanks for the information, Kubeflow requires k8s 1.8, does this feature exist in 1.8?

nop, but this may make other contributor confuse.

BTW, I think it should be client-go 1.8, k8s 1.11 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants