This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Support for PodGroup updates #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
|
@johnugeorge Can we wait to create a new kubeflow/common release until this PR is merged? |
are you referring |
Ah, yes. This is a typo. |
tenzen-y
force-pushed
the
can-update-podgroup
branch
from
65bcf75
to
48abbc9
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
can-update-podgroup
branch
from
48abbc9
to
74186bf
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com
Currently, when users update CustomJob resources (e.g, TFJob) with
runPolicy.schedulingPolicyorreplicaschanges, traininig-operator can not update PodGroup.This means when hpa-controller updates
replicas, training-operator does not update PodGroup.So I implemented the logic to update PodGroup.
/assign @zw0610 @johnugeorge @terrytangyuan