Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Add terrytangyuan to OWNERS #4

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Add terrytangyuan to OWNERS #4

merged 1 commit into from
Apr 3, 2019

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Apr 2, 2019 •
edited by jlewi
Loading

This change is Reviewable

@richardsliu
Copy link
Contributor Author

/assign @terrytangyuan

terrytangyuan
terrytangyuan approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@k8s-ci-robot
Copy link

@terrytangyuan: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

Thanks!
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gaocegege
gaocegege approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

@gaocegege: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardsliu richardsliu merged commit 5b981cb into kubeflow:master Apr 3, 2019
georgkaleido pushed a commit to georgkaleido/common that referenced this pull request Jun 9, 2022
@angerrp @dabauxi
Added pip-tools for dependency management (kubeflow#4)
46eaf54 
* Added requirements.in and requirements-dev.in, Added update-requirements.sh script, Modified setup.py to read requirements.in

* Created requirements*.txt with pip-compile, Minor fix update-requirements.sh

Co-authored-by: Paul Angerer <dabauxi@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaocegege gaocegege gaocegege approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardsliu @k8s-ci-robot @terrytangyuan @gaocegege