This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
GetDefaultContainerPortNumber to GetDefaultContainerPortName #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jian-he can you review this ? |
|
LGTM |
|
@gaocegege can you look at this as well ? |
gaocegege
reviewed
Jun 12, 2019
There was a problem hiding this comment.
Looks good in general. Could you address @gaocegege’s comment?
job_controller/api/v1/interface.go
Outdated
| @@ -62,7 +62,7 @@ type ControllerInterface interface { | |||
| GetDefaultContainerName() string | |||
|
|
|||
| // Get the default container port number | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gaocegege @terrytangyuan @jian-he thanks for your comments. |
|
Thanks for your contribution! 🎉 👍 |
georgkaleido
pushed a commit
to georgkaleido/common
that referenced
this pull request
Jun 9, 2022
…e in a specific Batch (kubeflow#41) * Add script to query Danni for the number of valid Dans at a given date * Add launcher for danni_count_batch.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to get the port name of container for each job, so we would change the port number to port name in the job controller interface.
This change is