Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

[hot-fix-43] change the job status api #44

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

merlintang
Copy link
Contributor

@merlintang merlintang commented Jun 18, 2019

what is proposed in this PR

this is related to issue. We need to update the job status in the function of updatejobstatus.

how to test this PR?

This is a interface for user to implement, and locally test on xgboost operator.


This change is Reviewable

@merlintang
Copy link
Contributor Author

@jian-he @terrytangyuan can you review this as well ?

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 09e1ac1 into kubeflow:master Jun 19, 2019
@merlintang
Copy link
Contributor Author

@gaocegege @terrytangyuan thanks for your kind help.

@merlintang merlintang deleted the hot-fix-43 branch June 19, 2019 01:38
georgkaleido pushed a commit to georgkaleido/common that referenced this pull request Jun 9, 2022
Co-authored-by: Paul Angerer <dabauxi@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants