This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Make container port optional #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
- Instead of using fixed port to communicate with each other, some frameworks randomly pick up port by worker and use auto-discovery to find entire topology. - In that case, we only need pod-to-pod communication and don’t need to specify port in headless service. - This give the flexibility for framework which doesn’t rely on fix port. Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
|
Rebase the master to resolve the conflict. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
georgkaleido
pushed a commit
to georgkaleido/common
that referenced
this pull request
Jun 9, 2022
* Create Dockerfile * Update core/requirements-deploy.txt * Update Dockerfile * Add missing jq dependency * Change python version Co-authored-by: jerome <jerome@kaleido.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #56
Signed-off-by: Jiaxin Shan seedjeffwan@gmail.com
I've tested in a controller using this common.