Import volcano api #62
Conversation
|
This change is |
|
|
| k8s.io/code-generator v0.15.10 | ||
| k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30 | ||
| k8s.io/kubernetes v1.15.10 | ||
| k8s.io/kubernetes v1.18.0 |
There was a problem hiding this comment.
Can we try to minimize the dependency changes? Another thing is k8s.io/Kubernetes version doesn't match with apimachinery and client-go
There was a problem hiding this comment.
+1 to keep current version :) Is there any reason for that?
There was a problem hiding this comment.
Actually we import 1.15.10, you can see the replace below. This is autogenrerated
There was a problem hiding this comment.
Em. It must be some libraries requires high version? I notice volcano go.mod requires 1.16.9 https://github.com/volcano-sh/volcano/blob/9c314bd9e262413be6a902ae1dc6dbe133732ca5/go.mod#L49-L54
which matches apimachinery and client-go version here. k8s.io/kubernetes must be from other libraries.
| @@ -66,8 +66,8 @@ type JobController struct { | |||
| // KubeClientSet is a standard kubernetes clientset. | |||
| KubeClientSet kubeclientset.Interface | |||
|
|
|||
| // KubeBatchClientSet is a standard kube-batch clientset. | |||
| KubeBatchClientSet kubebatchclient.Interface | |||
There was a problem hiding this comment.
I think my question is, do we want to have some backward compatibility or do we want to support different backends in case some one want to use kube-batch instead of valcano?
There was a problem hiding this comment.
Stand on my own point, as volcano is more actively maintained, it is better to migrate to it in the next release
There was a problem hiding this comment.
How much efforts would there be to support multiple backends? Would it be possible to make it pluggable?
There was a problem hiding this comment.
One way is to update NewJobController, and add a new argument to indicate whether to use volcano or kube-batch. Then it will require all the operators to change. I think it is not worth doing that.
Agree, i just follow the previous way |
| @@ -51,6 +41,7 @@ replace ( | |||
| k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.15.10 | |||
| k8s.io/kubectl => k8s.io/kubectl v0.15.11-beta.0 | |||
| k8s.io/kubelet => k8s.io/kubelet v0.15.10 | |||
| k8s.io/kubernetes => k8s.io/kubernetes v1.15.10 | |||
There was a problem hiding this comment.
@Jeffwan please see here
Yes let's delete it. |
There was a problem hiding this comment.
@hzxuzhonghu Please help rebase the changes, I remove vendor dependencies in a separate PR. This will makes PR clean.
| k8s.io/code-generator v0.15.10 | ||
| k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30 | ||
| k8s.io/kubernetes v1.15.10 | ||
| k8s.io/kubernetes v1.18.0 |
There was a problem hiding this comment.
Em. It must be some libraries requires high version? I notice volcano go.mod requires 1.16.9 https://github.com/volcano-sh/volcano/blob/9c314bd9e262413be6a902ae1dc6dbe133732ca5/go.mod#L49-L54
which matches apimachinery and client-go version here. k8s.io/kubernetes must be from other libraries.
|
ok, will do |
|
looks good to me |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you all |
Volcano is now being in the process of becoming a CNCF sandbox project. And many operators like tf-operator has already migrated to volcano scheduler
cncf/toc#318