Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Remove vendor dependencies #63

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Apr 10, 2020

This is last piece of work of #54.

We fully migrate to go modules, all go dependencies used in this project supports go module.

go build ./..., ./hack/update-codegen.sh and ./hack/verify-codegen.sh don't rely on vendor. It's unnecessary to keep it in code base

@kubeflow-bot
Copy link

This change is Reviewable

@Jeffwan
Copy link
Member Author

Jeffwan commented Apr 10, 2020

/assign @terrytangyuan

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f47bcca into kubeflow:master Apr 10, 2020
@Jeffwan Jeffwan deleted the remove_vendor branch April 10, 2020 18:36
georgkaleido pushed a commit to georgkaleido/common that referenced this pull request Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants