Reformat code with go fmt and check this on Travis CI

.travis.yml

@@ -14,6 +14,7 @@ install:
 script:
   - ./hack/verify-codegen.sh
   - go build ./...
+  - go fmt ./...
   - golangci-lint run --config=linter_config.yaml ./...
   # Here we run all tests in pkg and we have to use `-ignore`
   # since goveralls uses `filepath.Match` to match ignore files

go.mod

@@ -5,7 +5,6 @@ go 1.13
 require (
 	github.com/ghodss/yaml v1.0.0 // indirect
 	github.com/go-openapi/spec v0.19.2
-	github.com/gogo/protobuf v1.1.1 // indirect
 	github.com/golang/groupcache v0.0.0-20190129154638-5b532d6fd5ef // indirect
 	github.com/google/btree v1.0.0 // indirect
 	github.com/googleapis/gnostic v0.2.0 // indirect

pkg/controller.v1/common/job_controller.go

@@ -12,6 +12,7 @@ import (
 	corelisters "k8s.io/client-go/listers/core/v1"
 
 	apiv1 "github.com/kubeflow/common/pkg/apis/common/v1"
+	"github.com/kubeflow/common/pkg/controller.v1/expectation"
 	log "github.com/sirupsen/logrus"
 	policyapi "k8s.io/api/policy/v1beta1"
 	k8serrors "k8s.io/apimachinery/pkg/api/errors"
@@ -22,7 +23,6 @@ import (
 	"k8s.io/client-go/tools/record"
 	"k8s.io/client-go/util/workqueue"
 	"volcano.sh/volcano/pkg/apis/scheduling/v1beta1"
-	"github.com/kubeflow/common/pkg/controller.v1/expectation"
 	volcanoclient "volcano.sh/volcano/pkg/client/clientset/versioned"
 )
 

pkg/controller.v1/common/service.go

@@ -22,15 +22,15 @@ import (
 	"github.com/kubeflow/common/pkg/controller.v1/control"
 	"github.com/kubeflow/common/pkg/controller.v1/expectation"
 	commonutil "github.com/kubeflow/common/pkg/util"
+	"github.com/prometheus/client_golang/prometheus"
+	"github.com/prometheus/client_golang/prometheus/promauto"
 	log "github.com/sirupsen/logrus"
 	"k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apimachinery/pkg/runtime"
-	"github.com/prometheus/client_golang/prometheus"
-	"github.com/prometheus/client_golang/prometheus/promauto"
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 )
 

pkg/controller.v1/common/service_test.go

@@ -4,9 +4,9 @@ import (
 	"testing"
 
 	apiv1 "github.com/kubeflow/common/pkg/apis/common/v1"
+	"github.com/stretchr/testify/assert"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"github.com/stretchr/testify/assert"
 )
 
 func TestCalculateServiceSliceSize(t *testing.T) {

pkg/controller.v1/control/controller_ref_manager_test.go

@@ -30,10 +30,10 @@ func TestClaimPods(t *testing.T) {
 	controllerUID := "123"
 
 	type test struct {
-		name     string
-		manager  *PodControllerRefManager
-		pods []*v1.Pod
-		claimed  []*v1.Pod
+		name    string
+		manager *PodControllerRefManager
+		pods    []*v1.Pod
+		claimed []*v1.Pod
 	}
 	var tests = []test{
 		func() test {
@@ -54,8 +54,8 @@ func TestClaimPods(t *testing.T) {
 					testJobLabelSelector,
 					testjobv1.SchemeGroupVersionKind,
 					func() error { return nil }),
-				pods: []*v1.Pod{testutilv1.NewBasePod("pod1", testJob, t), testPod},
-				claimed:  []*v1.Pod{testutilv1.NewBasePod("pod1", testJob, t)},
+				pods:    []*v1.Pod{testutilv1.NewBasePod("pod1", testJob, t), testPod},
+				claimed: []*v1.Pod{testutilv1.NewBasePod("pod1", testJob, t)},
 			}
 		}(),
 		func() test {
@@ -80,8 +80,8 @@ func TestClaimPods(t *testing.T) {
 					controllerLabelSelector,
 					testjobv1.SchemeGroupVersionKind,
 					func() error { return nil }),
-				pods: []*v1.Pod{testPod1, testPod2},
-				claimed:  nil,
+				pods:    []*v1.Pod{testPod1, testPod2},
+				claimed: nil,
 			}
 		}(),
 		func() test {
@@ -104,8 +104,8 @@ func TestClaimPods(t *testing.T) {
 					controllerLabelSelector,
 					testjobv1.SchemeGroupVersionKind,
 					func() error { return nil }),
-				pods: []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t), testPod2},
-				claimed:  []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t)},
+				pods:    []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t), testPod2},
+				claimed: []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t)},
 			}
 		}(),
 		func() test {
@@ -126,8 +126,8 @@ func TestClaimPods(t *testing.T) {
 					controllerLabelSelector,
 					testjobv1.SchemeGroupVersionKind,
 					func() error { return nil }),
-				pods: []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t), testutilv1.NewBasePod("pod2", controller2, t)},
-				claimed:  []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t)},
+				pods:    []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t), testutilv1.NewBasePod("pod2", controller2, t)},
+				claimed: []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t)},
 			}
 		}(),
 		func() test {
@@ -148,8 +148,8 @@ func TestClaimPods(t *testing.T) {
 					controllerLabelSelector,
 					testjobv1.SchemeGroupVersionKind,
 					func() error { return nil }),
-				pods: []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t), testPod2},
-				claimed:  []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t)},
+				pods:    []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t), testPod2},
+				claimed: []*v1.Pod{testutilv1.NewBasePod("pod1", controller, t)},
 			}
 		}(),
 		func() test {
@@ -175,8 +175,8 @@ func TestClaimPods(t *testing.T) {
 					controllerLabelSelector,
 					testjobv1.SchemeGroupVersionKind,
 					func() error { return nil }),
-				pods: []*v1.Pod{testPod1, testPod2},
-				claimed:  []*v1.Pod{testPod1},
+				pods:    []*v1.Pod{testPod1, testPod2},
+				claimed: []*v1.Pod{testPod1},
 			}
 		}(),
 	}

pkg/controller.v1/control/pod_control.go

@@ -274,4 +274,4 @@ func (f *FakePodControl) Clear() {
 	f.Patches = [][]byte{}
 	f.CreateLimit = 0
 	f.CreateCallCount = 0
-}
+}

pkg/controller.v1/control/service_control.go

@@ -33,13 +33,13 @@ import (
 const (
 	// FailedCreateServiceReason is added in an event and in a job controller condition
 	// when a service for a job is failed to be created.
-	FailedCreateServiceReason     = "FailedCreateService"
+	FailedCreateServiceReason = "FailedCreateService"
 	// SuccessfulCreateServiceReason is added in an event when a service for a job
 	// is successfully created.
 	SuccessfulCreateServiceReason = "SuccessfulCreateService"
 	// FailedDeleteServiceReason is added in an event and in a job condition
 	// when a service for a job is failed to be deleted.
-	FailedDeleteServiceReason     = "FailedDeleteService"
+	FailedDeleteServiceReason = "FailedDeleteService"
 	// SuccessfulDeleteServiceReason is added in an event when a service for a job
 	// is successfully deleted.
 	SuccessfulDeleteServiceReason = "SuccessfulDeleteService"