Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note to indicate that mnist pipeline example does not currently work #726

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

amygdala
Copy link
Collaborator

@amygdala amygdala commented Feb 11, 2020

This change is Reviewable

@amygdala
Copy link
Collaborator Author

amygdala commented Feb 11, 2020

See kubeflow/pipelines#3037, kubeflow/website#1611 (comment)
We'll remove the related tutorial from the docs site as well, for now.

@@ -1,5 +1,7 @@
# MNIST Pipelines GCP

**This example does not currently work properly. It will be updated soon.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Replace "It will be updated soon." with something like:

For more information, see [kubeflow/website #1611](https://github.com/kubeflow/website/issues/1611) and [kubeflow/pipelines #3037](https://github.com/kubeflow/pipelines/issues/3037).

@amygdala
Copy link
Collaborator Author

thanks, PTAL again.

@joeliedtke
Copy link
Member

/lgtm

@amygdala
Copy link
Collaborator Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amygdala
To complete the pull request process, please assign karthikv2k
You can assign the PR to them by writing /assign @karthikv2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amygdala amygdala merged commit a467af7 into kubeflow:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants