Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Add documentation for dependency installation feature #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yashjakhotiya
Copy link

What this PR does / why we need it: Without documentation, users might struggle in installation of additional python packages in the built docker image required for fairing jobs. This PR mentions the special role of 'requirements.txt' in input_files list of ml_tasks.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #NONE

Special notes for your reviewer:

This is a documentation update PR

Release note:

NONE

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jinchihe
You can assign the PR to them by writing /assign @jinchihe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @yashjakhotiya. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yashjakhotiya
Copy link
Author

/assign @jinchihe

@jinchihe
Copy link
Member

/ok-to-test

@jinchihe
Copy link
Member

/retest

@yashjakhotiya
Copy link
Author

@jinchihe this is only a documentation update. Ideally, this should not fail any presubmit test.

@jinchihe
Copy link
Member

@jinchihe this is only a documentation update. Ideally, this should not fail any presubmit test.

Yeah, that should be caused by test tenv, I will take a look later once get chance. Thanks.

@jinchihe
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@yashjakhotiya: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-fairing-presubmit 0505b25 link /test kubeflow-fairing-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jinchihe
Copy link
Member

jinchihe commented Jul 7, 2020

@yashjakhotiya The CI testing problem has been fixed, would you please fetch and rebase? thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants