Fix modelsave #52
Fix modelsave #52
Conversation
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
|
/assign @mitake For the changes in dlk. |
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
YujiOshima
force-pushed
the
fix-modelsave
branch
from
14a5b16
to
09cfc03
Compare
| err := lt.checkPodStatus(podState) | ||
| if err != nil { | ||
| fmt.Println(err.Error()) | ||
| os.Exit(1) | ||
| } | ||
| lt.pollJobs() |
There was a problem hiding this comment.
What is the motivation of swapping pollJobs() and checkPodStatus()?
There was a problem hiding this comment.
If pollJobs is called before checkPodStatus, when logs of pod updated and the pod completed after pollJobs was called, the last logs won't be collected by dlk.
YujiOshima
force-pushed
the
fix-modelsave
branch
from
9847353
to
4ccd554
Compare
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
YujiOshima
force-pushed
the
fix-modelsave
branch
from
4ccd554
to
b818ac9
Compare
|
@gaocegege the change of dlk side looks good to me |
|
/lgtm @mitake Thanks :-) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix bug that the last trial of the study won't be saved when a study has completed.
I changed to save models of all completed trials before breaking
trialIteration.