Skip to content

Commit

Permalink
fix: update kubeflow admin config. Fixes #384 (#385)
Browse files Browse the repository at this point in the history
* fix: update kubeflow admin config. Fixes #384

* update
  • Loading branch information
Bobgy authored Nov 5, 2020
1 parent e4ad312 commit a27637e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion github-orgs/kubeflow/org.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ orgs:
- googlebot
- james-jwu
- k8s-ci-robot
- rmgogogo
billing_email: vishnukanan@gmail.com
company: ""
default_repository_permission: read
Expand Down Expand Up @@ -225,6 +224,7 @@ orgs:
- RFMVasconcelos
- richardsliu
- rlenferink
- rmgogogo
- rongou
- rpasricha
- rui5i
Expand Down
2 changes: 1 addition & 1 deletion github-orgs/manifests/validate_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def check_config(seld, config):
# Check that each admin is in a whitelist set of admins.
allowed_admins = ["Bobgy", "chensun",
"google-admin", "googlebot", "james-jwu", "jlewi",
"k8s-ci-robot", "rmgogogo", "theadactyl"]
"k8s-ci-robot", "theadactyl"]

for a in admins:
if not a in allowed_admins:
Expand Down
13 changes: 6 additions & 7 deletions github-orgs/sync_org.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,18 @@ usage() {

if [ -z ${test_infra_dir} ]; then
usage
exit 1
exit 1
fi

if [ -z ${token_file} ]; then
usage
exit 1
exit 1
fi

if [ -z ${confirm} ]; then
echo confirm not set defaulting to dryrun mode
confirm=false
fi
fi
pushd .
cd ${test_infra_dir}

Expand All @@ -69,14 +69,13 @@ elif [ "${action}" == "sync" ]; then
--fix-team-members \
--fix-org-members ${FIX_ADMINS} --config-path ${DIR}/kubeflow/org.yaml \
--github-token-path ${token_file} \
--required-admins=jlewi \
--required-admins=abhi-g \
--required-admins=Bobgy \
--required-admins=james-jwu \
--required-admins=google-admin \
--required-admins=googlebot \
--required-admins=richardsliu \
--confirm=${confirm}
echo "Note: if dryrun=true you might get errors updating groups if the group doesn't exist"
else
else
echo "command=${action} is not a valid command; valid commands are dump and sync"
exit 1
fi

0 comments on commit a27637e

Please sign in to comment.