Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated org.yaml to add me as member #248

Closed
wants to merge 8 commits into from
Closed

Updated org.yaml to add me as member #248

wants to merge 8 commits into from

Conversation

raviranjan0309
Copy link
Contributor

I had raised an issue regarding implement Kubeflow fairing from Kubeflow pipeline.
That was confirmed by Kubeflow core dev team. I have raised 2 PRs to resolve this issue.

I would like to join Kubeflow GitHub Org to connect and contribute more.

References:
kubeflow/pipelines#3742
kubeflow/fairing#494
kubeflow/manifests#1180
kubeflow/fairing#495

@raviranjan0309
Updated org.yaml to add me as member
570a45a 
I had raised an issue regarding implement Kubeflow fairing from Kubeflow pipeline.
That was confirmed by Kubeflow core dev team. I have raised 2 PRs to resolve this issue. 

I would like to join Kubeflow GitHub Org to connect and contribute more.

References:
kubeflow/pipelines#3742
kubeflow/fairing#494
kubeflow/manifests#1180
kubeflow/fairing#495
@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @raviranjan0309. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raviranjan0309
Copy link
Contributor Author

/assign @theadactyl

Please looking into my PR

terrytangyuan and others added 5 commits May 20, 2020 10:20
@terrytangyuan
Add myself to release team (#247)
dd30436 
* Add myself to release team

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>

* Update org.yaml

* Alphabetize

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@jlewi
Update github config with latest team permissions (#250)
d95b8b7 
* Per #228 we want to start using peribolos to sync team repo permissions

* Before we do that we need to sync config with the current team repo
  permissions so we don't lose those.

* Remove ajayalfred because that user doesn't exist and is breaking
  org syncs.

* Add jessiezcc as a member
@terrytangyuan
Specify repos for operator teams and add mxnet-operator team (#251)
bd6abae 
* Specify write access for operator teams and add mxnet-operator team

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>

* Add mxnet-operator to project-maintainers

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@terrytangyuan
Add back members from Ant Financial that went missing (#252)
16f232b
@Jeffwan
Add AWS Team and add Jeffwan@ to kubeflow/common team (#246)
e4303ff
@jlewi
Copy link
Contributor

jlewi commented May 22, 2020

/ok-to-test
Please rebase to pull in latest changes.

@raviranjan0309
Updated org.yaml to add me as member
eea331d 
I had raised an issue regarding implement Kubeflow fairing from Kubeflow pipeline.
That was confirmed by Kubeflow core dev team. I have raised 2 PRs to resolve this issue. 

I would like to join Kubeflow GitHub Org to connect and contribute more.

References:
kubeflow/pipelines#3742
kubeflow/fairing#494
kubeflow/manifests#1180
kubeflow/fairing#495
@raviranjan0309
rebase with master
b7bf2e9
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jlewi
You can assign the PR to them by writing /assign @jlewi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raviranjan0309
Copy link
Contributor Author

@jlewi I did rebase with the master for my feature branch patch-1. Could you please approve now?

@raviranjan0309
Copy link
Contributor Author

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented May 26, 2020

@raviranjan0309 Are you sure you rebased correctly? Or maybe you got out of sync? Either way the diff shows all kinds of other unrelated changes other than simply adding you as a member. There were a couple big PRs that went in last week and its likely you are missing those when you last rebased.

@raviranjan0309
Copy link
Contributor Author

@jlewi I have created a fresh PR resolving all the latest changes, now the feature branch is 1 commit ahead of kubeflow:master. Could you please approve now?

New PR - #253

@jlewi jlewi closed this May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardsliu richardsliu Awaiting requested review from richardsliu

@theadactyl theadactyl Awaiting requested review from theadactyl

Assignees

@jlewi jlewi

@theadactyl theadactyl

Labels
ok-to-test size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@raviranjan0309 @kubeflow-bot @k8s-ci-robot @jlewi @theadactyl @terrytangyuan @Jeffwan