Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FPGA OWNERS to member list #497

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

andreyvelich
Copy link
Member

Adding @eliaskoromilas and @jstamel to the Kubeflow member list. It helps us to define OWNERS file under FPGA examples in Katib repository.
Ref PR: kubeflow/katib#1685.

/assign @Bobgy @zijianjoy

/cc @eliaskoromilas @jstamel @gaocegege @johnugeorge

@google-oss-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: eliaskoromilas, jstamel.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Adding @eliaskoromilas and @jstamel to the Kubeflow member list. It helps us to define OWNERS file under FPGA examples in Katib repository.
Ref PR: kubeflow/katib#1685.

/assign @Bobgy @zijianjoy

/cc @eliaskoromilas @jstamel @gaocegege @johnugeorge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zijianjoy
Copy link
Contributor

/approve

Thank you for managing the owner scope on Katib!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 3d922bf into kubeflow:master Sep 29, 2021
@andreyvelich andreyvelich deleted the add-eliaskoromilas branch September 29, 2021 15:42
judahrand pushed a commit to judahrand/internal-acls that referenced this pull request Oct 4, 2021
zijianjoy pushed a commit to zijianjoy/internal-acls that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants