Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor README fixes #688

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Minor README fixes #688

merged 3 commits into from
Jul 24, 2024

Conversation

anishasthana
Copy link
Contributor

  1. Fix lint errors in README
  2. Remove dead link to slack channel

@anishasthana
Minor README fixes
223ddab 
1. Fix lint errors in README
2. Remove dead link to slack channel

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@google-oss-prow Google OSS Prow
Copy link

Hi @anishasthana. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@anishasthana
Remove stale slack link from issue template
626d2aa 
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana
Further membership issue template fixes
33946c9 
1. Remove the area/process label as it doesn't seem to exist in the repo.
examples: kubeflow#639 (comment), kubeflow#689 (comment)
2. Improve structure of the issue template

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Jul 24, 2024
@anishasthana anishasthana mentioned this pull request Jul 24, 2024
Merged
terrytangyuan
terrytangyuan approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 24, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b453144 into kubeflow:master Jul 24, 2024
2 checks passed
@anishasthana anishasthana deleted the fix_readme branch July 24, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@terrytangyuan terrytangyuan

Labels
approved lgtm needs-ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anishasthana @terrytangyuan