Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds @lucferbux as a member #726

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Nov 21, 2024

Membership Request

This PR adds @lucferbux as a member and closes #725

He has contributed significantly to the Model Registry UI and Backend (BFF) work (https://github.com/kubeflow/model-registry/commits?author=lucferbux) and is also the point of contact for the roadmap in Model Registry UI.

Please provide links to PRs or other contributions (2-3):
kubeflow/model-registry#233
kubeflow/model-registry#289
kubeflow/model-registry#299
kubeflow/model-registry#316
kubeflow/model-registry#345
kubeflow/model-registry#350
kubeflow/model-registry#360
kubeflow/model-registry#396
kubeflow/model-registry#423
kubeflow/model-registry#431
kubeflow/model-registry#445
kubeflow/model-registry#467
kubeflow/model-registry#470
kubeflow/model-registry#542
kubeflow/model-registry#559

Please list 2 existing members who are sponsoring your membership:

@ederign
@tarilabs

Please test your PR

Run

cd github_orgs
pytest test_org_yaml.py

Include the output in the PR

====================================================================== test session starts ======================================================================
platform darwin -- Python 3.13.0, pytest-7.4.4, pluggy-1.0.0
rootdir: /Users/ederign/src/kubeflow/internal-acls/github-orgs
collected 1 item

test_org_yaml.py .                                                                                                                                        [100%]

======================================================================= 1 passed in 0.05s =======================================================================

Additional Instructions

After your PR is merged please wait at least 1 hour for changes to propogate.

If after an hour you haven't recieved an invite to join the GitHub org please open an issue.

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
@rimolive
Copy link
Member

+1

1 similar comment
@alexcreasy
Copy link

+1

@tarilabs
Copy link
Member

I confirm I'm happy to sponsor this request!

/lgtm

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great contributions @lucferbux!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5701ecc into kubeflow:master Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lucferbux as Member of Kubeflow org
5 participants