Skip to content

Commit

Permalink
update test names
Browse files Browse the repository at this point in the history
Signed-off-by: helenxie-bit <helenxiehz@gmail.com>
  • Loading branch information
helenxie-bit committed Oct 10, 2024
1 parent 3ebbe76 commit 0498237
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions sdk/python/v1beta1/kubeflow/katib/api/katib_client_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ def __init__(

test_tune_data = [
(
"not specify name",
"missing name",
{
"name": None,
"objective": lambda x: x,
Expand All @@ -384,7 +384,7 @@ def __init__(
ValueError,
),
(
"set both options",
"invalid hybrid parameters - objective and model_provider_parameters",
{
"name": "tune_test",
"objective": lambda x: x,
Expand All @@ -393,46 +393,46 @@ def __init__(
ValueError,
),
(
"set no option",
"missing parameters",
{
"name": "tune_test",
},
ValueError,
),
(
"set one option but missing parameters - only objective",
"missing parameters in custom objective tuning - lack parameters",
{
"name": "tune_test",
"objective": lambda x: x,
},
ValueError,
),
(
"set one option but missing parameters - only parameters",
"missing parameters in custom objective tuning - lack objective",
{
"name": "tune_test",
"parameters": {"param": "value"},
},
ValueError,
),
(
"set one option but missing parameters - only model_provider_parameters",
"missing parameters in external model tuning - lack dataset_provider_parameters and trainer_parameters",
{
"name": "tune_test",
"model_provider_parameters": HuggingFaceModelParams(),
},
ValueError,
),
(
"set one option but missing parameters - only dataset_provider_parameters",
"missing parameters in external model tuning - lack model_provider_parameters and trainer_parameters",
{
"name": "tune_test",
"dataset_provider_parameters": HuggingFaceDatasetParams(),
},
ValueError,
),
(
"set one option but missing parameters - only trainer_parameters",
"missing parameters in external model tuning - lack model_provider_parameters and dataset_provider_parameters",
{
"name": "tune_test",
"trainer_parameters": HuggingFaceTrainerParams(),
Expand Down Expand Up @@ -491,7 +491,7 @@ def __init__(
RuntimeError,
),
(
"valid flow with custom objective",
"valid flow with custom objective tuning",
{
"name": "tune_test",
"namespace": "tune",
Expand All @@ -501,7 +501,7 @@ def __init__(
TEST_RESULT_SUCCESS,
),
(
"valid flow with external models and datasets",
"valid flow with external model tuning",
{
"name": "tune_test",
"namespace": "tune",
Expand Down

0 comments on commit 0498237

Please sign in to comment.