Skip to content

Commit

Permalink
Enable make check only for v1alpha3, disable Go linters
Browse files Browse the repository at this point in the history
  • Loading branch information
andreyvelich committed Jun 5, 2020
1 parent 7fb8b0d commit 1868e6b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ jobs:
# get coveralls.io support
- go get github.com/mattn/goveralls
script:
# TODO (andreyvelich): Disable check until we implement new Trial Template API logic in v1beta1
# - make check
- make check
- make test
- goveralls -coverprofile=coverage.out
- name: "Prettier frontend check"
Expand Down
14 changes: 10 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,21 @@ endif
check: fmt vet lint

fmt: depend generate
hack/verify-gofmt.sh
# TODO (andreyvelich): Disable until we implement new Trial Template API logic
# hack/verify-gofmt.sh

lint: depend generate
ifndef HAS_LINT
go get -u golang.org/x/lint/golint
echo "installing golint"
endif
hack/verify-golint.sh
# TODO (andreyvelich): Disable until we implement new Trial Template API logic
# hack/verify-golint.sh

vet: depend generate
go vet ./pkg/... ./cmd/...
# TODO (andreyvelich): Run only v1alpha3 test until we implement new Trial Template API logic in v1beta1
# go vet ./pkg/... ./cmd/...
go vet $(go list ./pkg/... ./cmd/... | grep -v v1beta1)

update:
hack/update-gofmt.sh
Expand All @@ -56,7 +60,9 @@ generate:
ifndef GOPATH
$(error GOPATH not defined, please define GOPATH. Run "go help gopath" to learn more about GOPATH)
endif
go generate ./pkg/... ./cmd/...
# TODO (andreyvelich): Run only v1alpha3 test until we implement new Trial Template API logic in v1beta1
# go generate ./pkg/... ./cmd/...
go generate $(go list ./pkg/... ./cmd/... | grep -v v1beta1)

# Build images for Katib v1alpha3 components
buildv1alpha3: depend generate
Expand Down

0 comments on commit 1868e6b

Please sign in to comment.