Fix sql syntax for UpdateAlgorithmExtraSettings (#633)

kubeflow · Jun 5, 2019 · 2d059a4 · 2d059a4
1 parent 77ae12d
commit 2d059a4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/db/v1alpha2/interface.go b/pkg/db/v1alpha2/interface.go
@@ -386,7 +386,7 @@ func (d *dbConn) UpdateAlgorithmExtraSettings(experimentName string, extraAlgori
 		isin := false
 		for _, ceas := range aesList {
 			if ceas.Name == neas.Name {
-				_, err = d.db.Exec(`UPDATE extra_algorithm_settings SET value = ? ,
+				_, err = d.db.Exec(`UPDATE extra_algorithm_settings SET value = ?
 						WHERE experiment_name = ? AND setting_name = ?`,
 					neas.Value, experimentName, ceas.Name)
 				if err != nil {

diff --git a/pkg/db/v1alpha2/interface_test.go b/pkg/db/v1alpha2/interface_test.go
@@ -239,7 +239,7 @@ func TestUpdateAlgorithmExtraSettings(t *testing.T) {
 		),
 	)
 
-	mock.ExpectExec(`UPDATE extra_algorithm_settings SET value = \? ,
+	mock.ExpectExec(`UPDATE extra_algorithm_settings SET value = \?
 	WHERE experiment_name = \? AND setting_name = \?`,
 	).WithArgs(exAlgoSet[0].Value, exp_name, exAlgoSet[0].Name).WillReturnResult(sqlmock.NewResult(1, 1))