Skip to content

Commit

Permalink
fix(ui): update None Collector with Push Collector. (#2418)
Browse files Browse the repository at this point in the history
* fix(ui): update None Collector with Push Collector.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* fix(ui): replace some remaining None MC.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

---------

Signed-off-by: Electronic-Waste <2690692950@qq.com>
  • Loading branch information
Electronic-Waste authored Dec 4, 2024
1 parent 5212949 commit 3363964
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ export enum CollectorKind {
TFEVENT = 'TensorFlowEvent',
PROMETHEUS = 'PrometheusMetric',
CUSTOM = 'Custom',
NONE = 'None',
PUSH = 'Push',
}
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export type CollectorKind =
| 'TensorFlowEvent'
| 'PrometheusMetric'
| 'Custom'
| 'None';
| 'Push';

export interface HttpGet {
host?: string;
Expand Down
2 changes: 1 addition & 1 deletion pkg/ui/v1beta1/frontend/src/app/models/trial.k8s.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export type CollectorKind =
| 'TensorFlowEvent'
| 'PrometheusMetric'
| 'Custom'
| 'None';
| 'Push';

export interface Objective {
type: ObjectiveType;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<mat-option [value]="kind.TFEVENT">TensorFlow Event</mat-option>
<mat-option [value]="kind.PROMETHEUS">Prometheus</mat-option>
<mat-option [value]="kind.CUSTOM">Custom</mat-option>
<mat-option [value]="kind.NONE">None</mat-option>
<mat-option [value]="kind.PUSH">Push</mat-option>
</mat-select>
</mat-form-field>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ export class ExperimentFormService {
collector: { kind },
};

if (kind === 'StdOut' || kind === 'None') {
if (kind === 'StdOut' || kind === 'Push') {
delete metrics.source;
return metrics;
}
Expand Down

0 comments on commit 3363964

Please sign in to comment.