fixes

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
kubeflow · Oct 8, 2024 · 748e4ba · 748e4ba
1 parent 81f5526
commit 748e4ba
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/examples/v1beta1/hp-tuning/hyperopt-distribution.yaml b/examples/v1beta1/hp-tuning/hyperopt-distribution.yaml
@@ -71,8 +71,4 @@ spec:
                   - "--batch-size=${trialParameters.batchSize}"
                   - "--lr=${trialParameters.learningRate}"
                   - "--momentum=${trialParameters.momentum}"
-                resources:
-                  limits:
-                    memory: "1Gi"
-                    cpu: "0.5"
-            restartPolicy: Never
+            restartPolicy: Never
diff --git a/pkg/suggestion/v1beta1/hyperopt/base_service.py b/pkg/suggestion/v1beta1/hyperopt/base_service.py
@@ -67,21 +67,20 @@ def create_hyperopt_domain(self):
             if param.type in [INTEGER, DOUBLE]:
                 if param.distribution == api_pb2.UNIFORM or param.distribution is None:
                     if param.step:
-                        hyperopt_search_space[param.name] = hyperopt.hp.quniform(
+                        hyperopt_search_space[param.name] = hyperopt.hp.quniformint(
                             param.name,
                             float(param.min),
                             float(param.max),
                             float(param.step),
                         )
+                    elif param.type == INTEGER:
+                        hyperopt_search_space[param.name] = hyperopt.hp.uniformint(
+                            param.name, float(param.min), float(param.max)
+                        )
                     else:
-                        if param.type == INTEGER:
-                            hyperopt_search_space[param.name] = hyperopt.hp.uniformint(
-                                param.name, float(param.min), float(param.max)
-                            )
-                        else:
-                            hyperopt_search_space[param.name] = hyperopt.hp.uniform(
-                                param.name, float(param.min), float(param.max)
-                            )
+                        hyperopt_search_space[param.name] = hyperopt.hp.uniform(
+                            param.name, float(param.min), float(param.max)
+                        )
                 elif param.distribution == api_pb2.LOG_UNIFORM:
                     if param.step:
                         hyperopt_search_space[param.name] = hyperopt.hp.qloguniform(