filter on es

kubeflow · Nov 26, 2022 · a05ff34 · a05ff34
1 parent a0b2cb1
commit a05ff34
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient.go b/pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient.go
@@ -343,7 +343,7 @@ func (g *General) ConvertTrials(ts []trialsv1beta1.Trial) []*suggestionapi.Trial
  if t.IsMetricsUnavailable() {
  continue
  }
- if !t.IsObservationAvailable() {
+ if !t.IsObservationAvailable() && t.IsEarlyStopped() {
  continue
  }
  trial := &suggestionapi.Trial{

diff --git a/pkg/suggestion/v1beta1/skopt/base_service.py b/pkg/suggestion/v1beta1/skopt/base_service.py
@@ -73,7 +73,7 @@ def getSuggestions(self, trials, current_request_number):
  Get the new suggested trials with skopt algorithm.
  """
  logger.info("-" * 100 + "\n")
- logger.info("New GetSuggestions call\n")
+ logger.info("New GetSuggestions call with current request number: {}\n".format(current_request_number))
  skopt_suggested = []
  loss_for_skopt = []
  if len(trials) > self.succeeded_trials or self.succeeded_trials == 0:
@@ -113,8 +113,6 @@ def getSuggestions(self, trials, current_request_number):
 
  else:
  logger.error("Succeeded Trials didn't change: {}\n".format(self.succeeded_trials))
- logger.error("No new suggestions could be generated, return early..\n")
- return []
 
  logger.info("Running Optimizer ask to query new parameters for Trials\n")