Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readiness/liveness probes to vizier-core #268

Closed
2 tasks done
lkpdn opened this issue Nov 29, 2018 · 1 comment
Closed
2 tasks done

Add readiness/liveness probes to vizier-core #268

lkpdn opened this issue Nov 29, 2018 · 1 comment

Comments

@lkpdn
Copy link
Contributor

lkpdn commented Nov 29, 2018

Currently we don't make much use of readiness/liveness probe, though there are major cases where if those are to be installed, it would help cluster admins or users recognize and diagnose what is going on when some component goes bad. Let me write some down as my first thought.

  • 1). When vizier-db takes tens of seconds to boot up, which is quite normal especially if the components are cleanly deployed for the first time, vizier-core is unavailable in the meantime. We can tell vizier-core is ready once Katib manager successfully starts to listen.
  • 2). Normal liveness probe against 0.0.0.0:6789 seems the best, though we cannot tell whether or not the backend db is healthy, which would heavily affect much of katib manager's gRPC methods.
@lkpdn
Copy link
Contributor Author

lkpdn commented Dec 5, 2018

Richer implementation has been merged. Close this one.

@lkpdn lkpdn closed this as completed Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant