-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement gRPC Health Checking Protocol + add readiness/liveness probes to vizier-core #270
Implement gRPC Health Checking Protocol + add readiness/liveness probes to vizier-core #270
Conversation
Hi @lkpdn. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lkpdn Thank you for create this PR. |
@YujiOshima OK, I'll push a commit later. Thanks. |
Signed-off-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
7d4709f
to
2fea722
Compare
@YujiOshima patch size gets quite heavier so I split it up into seven logical commits. Please take another look, thanks. |
0d1e0cb
to
a71f195
Compare
Signed-off-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
a71f195
to
d72d268
Compare
Sorry about repeated forced push. Now all fixed, though I've just done testrun on my local minikube. |
Thanks!! |
Fixes: 61ac560 ("Add SelectOne() to VizierDBInterface") Signed-off-by: Koichiro Den <den@valinux.co.jp>
Sorry I forgot to update some test codebase. Pushed a commit.: 25012d4 |
/retest |
@lkpdn Thank you!! This is very helpful. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the review! |
(1) and (2) listed in Ref: #268. Plus, set timeout (https://github.com/go-sql-driver/mysql/#timeout) parameter so that vizier-core never get stuck in a fruitless and harmful manner.
This change is