Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vizier-db needs enhanced liveness/readiness checks #334

Closed
pdmack opened this issue Jan 21, 2019 · 4 comments · Fixed by #871
Closed

vizier-db needs enhanced liveness/readiness checks #334

pdmack opened this issue Jan 21, 2019 · 4 comments · Fixed by #871
Assignees

Comments

@pdmack
Copy link
Member

pdmack commented Jan 21, 2019

vizier-db pod is shown as "Running" after deployment but it actually is not fully configured if there was a problem with the katib-mysql PV not being writable.

OpenShift 3.11

$ oc logs vizier-db-7b4475c695-7vwt9
2019-01-21T14:33:28.470292Z 27562 [Note] Access denied for user 'UNKNOWN_USER'@'localhost' (using password: YES)
2019-01-21T14:33:30.469526Z 27563 [Note] Access denied for user 'UNKNOWN_USER'@'localhost' (using password: YES)
2019-01-21T14:33:32.471171Z 27564 [Note] Access denied for user 'UNKNOWN_USER'@'localhost' (using password: YES)
@jlewi
Copy link
Contributor

jlewi commented Mar 10, 2019

@johnugeorge @YujiOshima @richardsliu Any plans to fix this in time for 0.5? Or should we move it into 0.6?

@richardsliu
Copy link
Contributor

Moving this out of 0.5.

@gaocegege
Copy link
Member

MySQL liveness probe requires mysqladmin.

https://github.com/helm/charts/blob/master/stable/mysql/templates/deployment.yaml#L122

In our MySQL image, we missed mysqladmin

Ref docker-library/mysql#410

Thus it is hard to add a liveness probe. Going to replace the image with a new one with mysqladmin.

@gaocegege
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants