-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add liveness probe for DB #871
Conversation
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
/assign @johnugeorge Not sure if we should merge it before 0.7 It requires some change to kf/manifests, I think. |
This would help users right?. In that case, shall we add to kf/manifests too? |
It will be helpful. But there may be a blocker that we cannot upgrade from 8.0.3 to 8(8.0.17) painlessly. I need to delete /tmp/katib to clean the directory first. |
But I think it works for us since it solves #334 |
@gaocegege are you talking backward compatibility ? It is not compatible now anyways |
@johnugeorge Yeah, then I think we can merge it into kf/manifests. |
/lgtm |
I will wait for @hougangliu |
/approve |
/assign @hougangliu |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #334
Special notes for your reviewer:
Release note:
This change is