Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add liveness probe for DB #871

Merged
merged 2 commits into from
Oct 11, 2019
Merged

feat: Add liveness probe for DB #871

merged 2 commits into from
Oct 11, 2019

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Oct 11, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #334

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

/assign @johnugeorge

Not sure if we should merge it before 0.7

It requires some change to kf/manifests, I think.

@johnugeorge
Copy link
Member

This would help users right?. In that case, shall we add to kf/manifests too?

@gaocegege
Copy link
Member Author

It will be helpful. But there may be a blocker that we cannot upgrade from 8.0.3 to 8(8.0.17) painlessly. I need to delete /tmp/katib to clean the directory first.

@gaocegege
Copy link
Member Author

But I think it works for us since it solves #334

@johnugeorge
Copy link
Member

@gaocegege are you talking backward compatibility ? It is not compatible now anyways

@gaocegege
Copy link
Member Author

@johnugeorge Yeah, then I think we can merge it into kf/manifests.

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

I will wait for @hougangliu

@hougangliu
Copy link
Member

/approve

@gaocegege
Copy link
Member Author

/assign @hougangliu

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cefb6fe into kubeflow:master Oct 11, 2019
@gaocegege gaocegege deleted the db branch October 11, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vizier-db needs enhanced liveness/readiness checks
4 participants