Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric collector containers are not added when deployed in non kubeflow namespace #823

Closed
johnugeorge opened this issue Sep 26, 2019 · 5 comments
Closed

Metric collector containers are not added when deployed in non kubeflow namespace #823

johnugeorge opened this issue Sep 26, 2019 · 5 comments
Assignees
@hougangliu
Labels
kind/bug

Comments

@johnugeorge
Copy link
Member

/kind bug

/assign @hougangliu
@hougangliu
Copy link
Member

For now, metrics-collector sidecar container is only injected into the namespace with label katib-metricscollector-injection: enabled by design

@gaocegege
Copy link
Member

Yeah, I think it is a feature to avoid performance issues.

@gaocegege
Copy link
Member

We decided to add a validation webhook to avoid silent failure.

@gaocegege
Copy link
Member

I think we could close it. #828 fixed it.

/close

@k8s-ci-robot
Copy link

@gaocegege: Closing this issue.

In response to this:

I think we could close it. #828 fixed it.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hougangliu hougangliu

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@johnugeorge @gaocegege @hougangliu @k8s-ci-robot