Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few typos #1001

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Fixed a few typos #1001

merged 1 commit into from
Jan 7, 2020

Conversation

sarahmaddox
Copy link
Contributor

@sarahmaddox sarahmaddox commented Jan 7, 2020

What this PR does / why we need it:
Fixed some typos mentioned in the review of PR #990

I decided not to change the capitalisation of the headings, as suggested in the comments on the above PR, because capitalization is a style choice and the guide isn't part of a doc set where we're looking for consistency.)

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

This PR doesn't change any image versions.

Release note:

NONE

This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sarahmaddox
Copy link
Contributor Author

Wow, that was super fast - thanks @gaocegege!

@k8s-ci-robot k8s-ci-robot merged commit 03cec2e into kubeflow:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants