-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NAS RL training container to kubeflowkatib repository #1008
Add NAS RL training container to kubeflowkatib repository #1008
Conversation
examples/v1alpha3/README.md
Outdated
docker.io/kubeflowkatib/mxnet-mnist-example | ||
``` | ||
|
||
- Mxnet mnist example with collecting metrics time, [source](https://github.com/kubeflow/katib/blob/master/examples/v1alpha3/mxnet-mnist-timestamp/mnist.py). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it checked in?
Is earlier one required? Should we keep this as the default and rename to mxnet-mnist-example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR #970 is required for this.
We can keep it as default mxnet mnist example.
In that case, I will rename mxnet-mnist-timestamp to mxnet-mnist-example and we will collect metrics time in this example also. What do you think about it @johnugeorge ?
/cc @hougangliu @gaocegege
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree. thanks
I think so. Let’s see if others have a different suggestion . |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I deleted build for NAS training container from the CI and I pushed it to kubeflowkatib repository.
Also, I added in example README list of current Katib training container images with source links.
I think it would be great if we have all Katib related images in one place.
What do you think?
/cc @johnugeorge @hougangliu @gaocegege
This change is