Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of Trials problem in NAS RL Suggestion #1009

Merged

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Jan 9, 2020

I fixed bug in NAS RL Suggestion.
experiment.num_trials should be updated every GetSuggestions call, since request_number value can be different during one experiment.
Also, I change deprecated TF functions to decrease warning in Suggestion logs and I added logger instead of print in AlgorithmSettings.

/cc @johnugeorge @gaocegege @hougangliu


This change is Reviewable

Change tf deprecated functions
Add logger instead of print
@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0df05e9 into kubeflow:master Jan 10, 2020
@andreyvelich andreyvelich deleted the fix-rl-suggestion-trial-count branch October 6, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants