Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add antfin into list of adoptors #1025

Merged
merged 2 commits into from
Jan 20, 2020
Merged

add antfin into list of adoptors #1025

merged 2 commits into from
Jan 20, 2020

Conversation

sperlingxx
Copy link
Member

@sperlingxx sperlingxx commented Jan 20, 2020

Add antfin into list of adoptors.


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @sperlingxx. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

cc @johnugeorge

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

gaocegege commented Jan 20, 2020

@sperlingxx Thanks, and if you are interested in continuing to contribute in kubeflow community, suggest joining the kubeflow organization. Here is the documentation about the process: https://www.kubeflow.org/docs/about/contributing/#joining-the-kubeflow-github-org

  • Send a PR adding yourself as a member in org.yaml
  • After the PR is merged an admin will send you an invitation
    • This is a manual process that’s generally run a couple times a week
    • If a week passes without receiving an invitation reach out on kubeflow#community

There are already some members from Ant Financial, you can just add your name in https://github.com/kubeflow/internal-acls/blob/master/github-orgs/kubeflow/org.yaml#L243 and https://github.com/kubeflow/internal-acls/blob/master/github-orgs/kubeflow/org.yaml#L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants