Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add Trial Status to HP Job Table #1032

Merged

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Jan 27, 2020

Fixes #1030.

As well, I fixed error with date in Trial Metric Info. Since I changed formatTime to correct one in FetchHPJobTrialInfo function , we don't need to format date in the UI.

Trial Status

/assign @johnugeorge @gaocegege @hougangliu


This change is Reviewable

Fix problem with HP Job Trial metric info
@andreyvelich
Copy link
Member Author

/retest

1 similar comment
@andreyvelich
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7b91909 into kubeflow:master Jan 28, 2020
@andreyvelich andreyvelich deleted the issue-1030-trial-status-table branch October 6, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI Feature] Show Trials status in the table
5 participants