Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tell method for BO Suggestion #1055

Merged
merged 1 commit into from
Feb 15, 2020

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Feb 14, 2020

Fixes: #1052.

/assign @gaocegege @johnugeorge
/cc @richardsliu @hougangliu


This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

2 similar comments
@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

Can you add PR description

@andreyvelich
Copy link
Member Author

andreyvelich commented Feb 14, 2020

Can you add PR description

After this PR skopt_suggested will contain information of all Trials assignments and loss_for_skopt will be list of all Trials observation value. We will run tell method once with all Trials information instead of running it for every Trial.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@johnugeorge johnugeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit c8a6089 into kubeflow:master Feb 15, 2020
@andreyvelich andreyvelich deleted the issue-1052-fix-oom-error branch October 6, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OOM errors when number of trials is high
4 participants