Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Show best metrics in the Trial metrics information plot #1068

Merged

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Feb 24, 2020

If metrics have the same time, we should show metrics with best objective value in the Trial metrics information plot, instead of latest.
This PR fixes this problem.
Also, I added Trial name to the metrics plot.

/assign @johnugeorge


This change is Reviewable

@andreyvelich
Copy link
Member Author

/cc @gaocegege

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 969935e into kubeflow:master Feb 25, 2020
@andreyvelich andreyvelich deleted the ui-show-best-metrics-with-same-time branch October 6, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants