Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore: Add macOS, Windows and Go ignore files #11

Merged
merged 1 commit into from
Apr 6, 2018
Merged

ignore: Add macOS, Windows and Go ignore files #11

merged 1 commit into from
Apr 6, 2018

Conversation

gaocegege
Copy link
Member

The ignore is from https://github.com/github/gitignore.

/assign @YujiOshima

Signed-off-by: Ce Gao gaoce@caicloud.io

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@YujiOshima
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege merged commit 77c301b into kubeflow:master Apr 6, 2018
@gaocegege gaocegege deleted the ignore branch April 6, 2018 07:04
kuikuikuizzZ pushed a commit to kuikuikuizzZ/katib that referenced this pull request Jan 20, 2021
…ow#11)

* feat(experiment): Add a check before deletion

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Delete all trials

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* feat: Implement in v1beta1

Signed-off-by: Ce Gao <gaoce@caicloud.io>

Co-authored-by: whalecold <zhenglisheng@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants