Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor python files in cmd/suggestion #1105

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Mar 24, 2020

What this PR does / why we need it:

  • Remove __init__.py from cmd/suggestion/**/__init__.py because that are not python import modules, just providing a command-line entrypoint.
  • Follow pep8.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

None.

Special notes for your reviewer:

None.

Release note:

NONE

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @c-bata. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c-bata
Copy link
Member Author

c-bata commented Mar 24, 2020

/assign @gaocegege

@gaocegege
Copy link
Member

/ok-to-test

@c-bata
Copy link
Member Author

c-bata commented Mar 24, 2020

/retest

2 similar comments
@johnugeorge
Copy link
Member

/retest

@c-bata
Copy link
Member Author

c-bata commented Mar 24, 2020

/retest

@johnugeorge
Copy link
Member

Thanks @c-bata
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 533ca35 into kubeflow:master Mar 24, 2020
@c-bata c-bata deleted the cleaup-cmd-suggestion branch March 24, 2020 15:11
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants