Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support step for int parameter in Chocolate and Hyperopt Suggestion #1123

Merged

Conversation

andreyvelich
Copy link
Member

Fixes: #1119.

I added parsing step in Internal Search Space function.
Default value for the int parameter step is 1.

/assign @gaocegege
/cc @StefanoFioravanzo

@k8s-ci-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: StefanoFioravanzo.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: #1119.

I added parsing step in Internal Search Space function.
Default value for the int parameter step is 1.

/assign @gaocegege
/cc @StefanoFioravanzo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeflow-bot
Copy link

This change is Reviewable

@StefanoFioravanzo
Copy link
Member

@andreyvelich I see that the bot does not allow me to be a reviewer. I understand that I should add myself to https://github.com/kubeflow/internal-acls? Maybe to devrel-team.members.txt? cc @jlewi

@andreyvelich
Copy link
Member Author

@StefanoFioravanzo I believe you should be a Kubeflow member to left the review (https://github.com/kubeflow/internal-acls/blob/master/github-orgs/kubeflow/org.yaml#L23).
Right @jlewi ?

@jlewi
Copy link
Contributor

jlewi commented Apr 5, 2020

Yes to LGTM PRs you will need to become a member of the org. To become a member of the org you should have made contributions that you can point to in the PR applying to join.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cd27da5 into kubeflow:master Apr 7, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
@andreyvelich andreyvelich deleted the issue-1119-grid-step-for-int branch October 6, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step field does not work with int parameters
6 participants