-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NotImplementedError for TPE and Random suggestion. #1130
Conversation
Hi @c-bata. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I also checked Before
After
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
FYI, This year we will add validation for all algortihms.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I deployed katib (rev ab3dab0) to my kubernetes cluster, then applied this experiment which specifies
random
as analgorithmName
attribute.I checked the implementation of
hyperopt
suggestion service, but it doesn't implementValidateAlgorithmSetttings
. So this method is called.I tested this patch on my Kubernetes cluster, then this problem is resolved. But I don't know what should I validate in this method, so I just added an empty implementation of
ValidateAlgorithmSettings
for now.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):None
Special notes for your reviewer:
tpe
algorithm.Release note:
I guess this bug was recently added.