Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NAS RL Suggestion #1134

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Conversation

andreyvelich
Copy link
Member

I Refactored NAS RL Suggestion code. I used https://github.com/google-research/google-research/tree/master/enas_lm in additional to original ENAS repository, since we will implement RNN search for Penn Treebank dataset.

Made few changes:

  1. Changed algorithm settings to be more clear to user and deleted them from original yaml files. We have to add documentation about these algorithm settings, for example in ENAS README.
  2. Deleted Controller lstm_num_layers. We were using only 1 layer of controller lstm, so it was useless. In the future, if we decide to implement this functionality, we can extend controller.
  3. Removed Trainer and LSTM file. Left only useful functions in Controller.
  4. Integrated Controller training. I think we should Train Controller after each succeeded Trial. User can specify controller_train_steps for how many steps Controller must be trained after each getSuggestion call.

Screenshot 2020-04-10 at 02 36 28

  1. Modified unit test with relevant example.

In the future PRs I:

  1. Change NAS RL to ENAS, we have issue for that.
  2. Modify UI with new Algorithm Settings.
  3. Check Algorithm Settings in ValidateAlgorithmSettings function.
  4. Enable to add None Algorithm Settings.

/assign @johnugeorge @gaocegege

@kubeflow-bot
Copy link

This change is Reviewable

@johnugeorge
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7fa4988 into kubeflow:master Apr 13, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
* Refactor NAS RL

* Remove comments

* Change format
@andreyvelich andreyvelich deleted the enas-refactor branch October 6, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants