Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Refactored NAS RL Suggestion code. I used https://github.com/google-research/google-research/tree/master/enas_lm in additional to original ENAS repository, since we will implement RNN search for Penn Treebank dataset.
Made few changes:
lstm_num_layers
. We were using only 1 layer of controller lstm, so it was useless. In the future, if we decide to implement this functionality, we can extend controller.controller_train_steps
for how many steps Controller must be trained after eachgetSuggestion
call.In the future PRs I:
ValidateAlgorithmSettings
function./assign @johnugeorge @gaocegege