Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor suggestion services folder structure #1166

Merged
merged 3 commits into from
Apr 26, 2020
Merged

Refactor suggestion services folder structure #1166

merged 3 commits into from
Apr 26, 2020

Conversation

andreyvelich
Copy link
Member

Fixes: #1144.

@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich
Copy link
Member Author

/assign @johnugeorge @gaocegege
/cc @c-bata

c-bata
c-bata approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@c-bata c-bata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!

It might be better to rename files like:

  • suggestion/chocolate/chocolate_service.py -> suggestion/chocolate/service.py
  • suggestion/hyperband/hyperbad_service.py -> suggestion/hyperbad/service.py
  • suggestion/skopt/skopt_service.py -> suggestion/skopt/service.py
  • ...

But I have no strong opinion about this. And we can work on it in another pull request.

/lgtm

@andreyvelich
Copy link
Member Author

Thank you for your work!

It might be better to rename files like:

  • suggestion/chocolate/chocolate_service.py -> suggestion/chocolate/service.py
  • suggestion/hyperband/hyperbad_service.py -> suggestion/hyperbad/service.py
  • suggestion/skopt/skopt_service.py -> suggestion/skopt/service.py
  • ...

But I have no strong opinion about this. And we can work on it in another pull request.

/lgtm

Good point. I will rename it.
What do you think about Base Services: https://github.com/andreyvelich/katib/blob/issue-1144-suggestion-folder-structure/pkg/suggestion/v1alpha3/chocolate/base_chocolate_service.py ?
Maybe name it base_service.py ?

@c-bata
Copy link
Member

c-bata commented Apr 24, 2020

Maybe name it base_service.py ?

Yeah, agree.

@c-bata
Copy link
Member

c-bata commented Apr 25, 2020

/lgtm

gaocegege
gaocegege reviewed Apr 26, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I think we do not need it.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 116f9f0 into kubeflow:master Apr 26, 2020
@c-bata c-bata mentioned this pull request Apr 26, 2020
Merged
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
@andreyvelich @sperlingxx
Refactor suggestion services folder structure (kubeflow#1166)
033450e 
* Refactor suggestion services folder structure

* Move base health service to internal

* Rename service and base service files
@andreyvelich andreyvelich deleted the issue-1144-suggestion-folder-structure branch October 6, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@c-bata c-bata c-bata approved these changes

@Akado2009 Akado2009 Awaiting requested review from Akado2009

@garganubhav garganubhav Awaiting requested review from garganubhav

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

@c-bata c-bata

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion services folder structure
6 participants
@andreyvelich @kubeflow-bot @c-bata @k8s-ci-robot @gaocegege @johnugeorge