Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify new algorithm service doc #1198

Merged
merged 2 commits into from
May 28, 2020
Merged

Modify new algorithm service doc #1198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16302fd
Add step to new algorithm service doc to modify check Katib ready script
andreyvelich May 27, 2020
46b54cc
Add link to script
andreyvelich May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/new-algorithm-service.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,13 @@ To add a e2e test for the new algorithm, in [test/scripts/v1alpha3](../test/scri

2. Create a new script `build-suggestion-xxx.sh` to build new suggestion. Here is an example [test/scripts/v1alpha3/build-suggestion-hyperopt.sh](../test/scripts/v1alpha3/build-suggestion-hyperopt.sh).

3. Create a new script `run-suggestion-xxx.sh` to run new suggestion. Below is an example (Replace `<name>` with the new algorithm name):
3. Update [`check-katib-ready.sh`](../test/scripts/v1alpha3/check-katib-ready.sh) script to modify `katib-config.yaml` with the new test suggestion image name. We use `gcr.io/kubeflow-ci` registry to run presubmit tests. For example (Replace `<name>` with the new suggestion name):

```
sed -i -e "s@gcr.io\/kubeflow-images-public\/katib\/v1alpha3\/suggestion-<name>@${REGISTRY}\/${REPO_NAME}\/v1alpha3\/suggestion-<name>@" manifests/v1alpha3/katib-controller/katib-config.yaml
```

4. Create a new script `run-suggestion-xxx.sh` to run new suggestion. Below is an example (Replace `<name>` with the new algorithm name):

```bash
#!/bin/bash
Expand Down