vendor: Add #12
vendor: Add #12
Conversation
Gopkg.toml
Outdated
|
|
||
| [[constraint]] | ||
| name = "github.com/docker/docker" | ||
| version = "1.13.1" |
There was a problem hiding this comment.
Note: this version is no longer maintained. I'd suggest syncing with the master.
There was a problem hiding this comment.
@AkihiroSuda Thanks for your advice, I will update it.
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
Addressed. PTAL |
Gopkg.toml
Outdated
|
|
||
| [[constraint]] | ||
| name = "github.com/docker/docker" | ||
| branch = "master" |
There was a problem hiding this comment.
nit: I guess you don't need to retain this constraint entry for the master branch
|
@gaocegege Thank you for great work! Each docker image is still using |
|
@YujiOshima Yeah, I think we could use multiple stage build to reuse the vendor to build binaries. |
|
@gaocegege Absolutely, It can reduce image size so much and accelerate images build. |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
I opened an issue to keep track of the process #14 |
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: whalecold <zhenglisheng@caicloud.io>
Close #5
Using dep to install all vendor dependencies.
/assign @YujiOshima