Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation to use spaces (instead of a mix of tabs and spaces) #121

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

vinaykakade
Copy link
Contributor

Let me know in case you prefer to use tabs everywhere. But, in general, it is better to use one consistently rather than a mix of both.

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

/assign @YujiOshima

@gaocegege
Copy link
Member

Thanks for your contribution!

Personally, I like spaces.

@YujiOshima
Copy link
Contributor

@vinaykakade Thanks! I also prefer space.
As the proto files were not formatted by go fmt, their style wouldn't be consistent.

@YujiOshima
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8f22850 into kubeflow:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants