Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend gRPC controller-algorithm communication & Add Suggestion state Exhausted #1213

Closed
wants to merge 7 commits into from
Closed

Extend gRPC controller-algorithm communication & Add Suggestion state Exhausted #1213

wants to merge 7 commits into from

Commits on Jun 9, 2020

  1. Chocolate: Return gRPC error when generating no new assignments 

    Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
    @elikatsis
    elikatsis committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    284cbfc View commit details
    Browse the repository at this point in the history

  2. Mark Suggestion failed if GetSuggestion gRPC fails 

    Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
    @elikatsis
    elikatsis committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    0855a16 View commit details
    Browse the repository at this point in the history

  3. Experiment: Wait for active trials when suggestion is failed 

    Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
    @elikatsis
    elikatsis committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    352a9f1 View commit details
    Browse the repository at this point in the history

  4. Suggestion: Continue if assignments returned are less than the requested 

    If get suggestions RPC fails when receiving less assignments than the
requested amount, we lose assignments and, thus, have less trials to
execute.
With this commit, we log the fact that there is a difference between the
two, however we proceed with experiment execution.

Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
    @elikatsis
    elikatsis committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    c0423b2 View commit details
    Browse the repository at this point in the history

  5. Suggestion: Introduce Suggestion Exhausted status 

    Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
    @elikatsis
    elikatsis committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    80005ab View commit details
    Browse the repository at this point in the history

  6. Suggestion: Mark suggestion as Exhausted if RPC returns NotFound 

    Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
    @elikatsis
    elikatsis committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    d5b1d53 View commit details
    Browse the repository at this point in the history

  7. Experiment: Use all assignments when Suggestion is failed/exhausted 

    When there is no Experiment goal, mark the Experiment as succeeded.
Else, if the goal is not reached, mark it as failed.
    @elikatsis
    elikatsis committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    697790f View commit details
    Browse the repository at this point in the history