-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken client-example.go #125
Conversation
Merge kubeflow/katib/master to lyft/katib/master
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have no error on client-example.go. |
I was also able to run client-example.go (last week) |
Thanks, I'll check for the mismatch between client and server. |
/ok-to-test |
@vinaykakade Were you successful? |
Yes, was able to run it long ago. Apologies for not reporting this sooner. Will close this PR. |
@vinaykakade How did you solve it? |
The issue was mismatched images in dockerhub and the tip of master. I had to rebuild the images, upload them to an image repository we use, and point the manifest for vizier-core to pull the image from our repository instead of dockerhub. |
With the recent changes in the repo (#110), I found that client-example.go no longer works. There are two issues:
(1) With having 'matrics\n - accuracy' in study-config, the CreateStudy request no longer is successful. Until the underlying cause is found/fixed, removing it from study-config. Let me know in case replacing it with something else works.
(2) Even after the workers terminate successfully, the client-example.go is no longer able to detect their termination and keeps on running in an infinite loop. Reverted to the original terminal condition change which works correctly.
/assign @YujiOshima