Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem with Hyperopt Out of Range error #1315

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Fix problem with Hyperopt Out of Range error #1315

merged 1 commit into from
Sep 3, 2020

Conversation

andreyvelich
Copy link
Member

See comment: #1314 (comment).
After this fix, we should not see list index out of range error.

/assign @gaocegege @sperlingxx
/cc @jimmy-hawkfish

@k8s-ci-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: jimmy-hawkfish.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

See comment: #1314 (comment).
After this fix, we should not see list index out of range error.

/assign @gaocegege @sperlingxx
/cc @jimmy-hawkfish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeflow-bot
Copy link

This change is Reviewable

sperlingxx
sperlingxx approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@sperlingxx sperlingxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

gaocegege
gaocegege reviewed Aug 27, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andreyvelich andreyvelich force-pushed the issue-1314-hyperopt-out-of-range-error branch from ecf435b to 1a60cf5 Compare September 1, 2020 13:14
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 1, 2020
@andreyvelich
Copy link
Member Author

/retest

1 similar comment
@johnugeorge
Copy link
Member

/retest

@johnugeorge
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/retest

1 similar comment
@johnugeorge
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 36aef5f into kubeflow:master Sep 3, 2020
@andreyvelich andreyvelich deleted the issue-1314-hyperopt-out-of-range-error branch October 6, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@sperlingxx sperlingxx sperlingxx approved these changes

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

@sperlingxx sperlingxx

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andreyvelich @k8s-ci-robot @kubeflow-bot @johnugeorge @gaocegege @sperlingxx