Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trial metadata substitution example #1319

Merged

Conversation

andreyvelich
Copy link
Member

Part of #1280.
I added example for trial metadata injection from template.

/assign @sperlingxx

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@sperlingxx sperlingxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for adding this!

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andreyvelich
Copy link
Member Author

/retest

2 similar comments
@andreyvelich
Copy link
Member Author

/retest

@gaocegege
Copy link
Member

/retest

@andreyvelich andreyvelich force-pushed the issue-1280-add-meta-example branch from 56d6c3a to 74504ff Compare September 17, 2020 17:23
@gaocegege
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6a07daa into kubeflow:master Sep 18, 2020
@andreyvelich andreyvelich deleted the issue-1280-add-meta-example branch October 6, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants