Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image registry to docker.io/kubeflowkatib #1372

Merged

Conversation

andreyvelich
Copy link
Member

Blocked by: #1371.

We have to change registry to docker.io/kubeflowkatib from gcr.io/kubeflow-images-public/katib/v1beta1.
I think, for the manifests we will use latest tag.
For the training container examples, I will add particular tag to fix: #1272.

As well, I added e2e test for early stopping.

/assign @gaocegege @johnugeorge

@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich andreyvelich force-pushed the change-registry-to-kubeflowkatib branch from 5f45061 to bd4b1f2 Compare November 1, 2020 03:51
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Nov 2, 2020
@andreyvelich
Copy link
Member Author

I changed images to the new registry.
As well, I fixed small problem with setting empty vars in UI.

Please, take a look @johnugeorge @gaocegege.

@andreyvelich andreyvelich changed the title [WIP] Change image registry to docker.io/kubeflowkatib Change image registry to docker.io/kubeflowkatib Nov 2, 2020
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1729997 into kubeflow:master Nov 4, 2020
@andreyvelich andreyvelich deleted the change-registry-to-kubeflowkatib branch October 6, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags for Training container images
5 participants